Remove footpads disabling LEDs on startup#74
Conversation
lukash
left a comment
There was a problem hiding this comment.
Thank you, code LGTM.
I'm using a git commit trailer mechanism for tracking changelog records, could you add such changelog record to the commit message? It'll also automatically attribute the change to the commit author name in the changelog. Just add a "Feature: ..." trailer, it's described in CONTRIBUTING.md, you can also check past commits for examples and you can run ./changelog.py to see what it outputs. (note I use a very crude mechanism for multiline formatted content of the git trailer, not proud of it but it does the job...)
My idea of what it should look like (feel free to improve it):
Feature: Don't disable LEDs if both sensors are pressed at startup
>
This mechanism was in place for the potential case of the LED
initialization locking up the board in a way that would prevent the
user from connecting and fixing the problem. This has proven unneeded,
so the feature is being removed.
29b892f to
d946206
Compare
|
I've amended with the feature tag added and the updated XML from VESC Tool. All looks good in changelog.py. |
|
@Eli-Parker I think you somehow managed to drop the code changes from the commit 😅 settings.xml looks good now, in the commit message ideally the "Remove the disabling of LEDs if both sensors are pressed during startup. Settings.xml LED Mode description is updated to reflect the change" line should be wrapped as it's too long (and it's missing a period 😁 ). |
|
My bad, it must've gotten dropped in the amend |
f83ba02 to
08874a3
Compare
Remove the disabling of LEDs if both sensors are pressed during startup. Settings.xml LED Mode description is updated to reflect the change. Feature: Don't disable LEDs if both sensors are pressed at startup > This mechanism was in place for the potential case of the LED initialization locking up the board in a way that would prevent the user from connecting to fix the problem. This has proven unneeded, so the feature is being removed.
08874a3 to
b3cf44a
Compare
|
I've verified that all the changes are back onto the commit. I seem to be having a few problems getting changelog.py to run, something about an invalid escape sequence '.'. Let me know if you notice anything else, sorry for the trouble with git. |
Remove the disabling of LEDs if both sensors are pressed during startup. Settings.xml LED Mode description is updated to reflect the change