Skip to content

Add localization key to placeholder#19

Open
Muhammadbarznji wants to merge 4 commits intolukeredpath:mainfrom
Muhammadbarznji:feature/support-localization
Open

Add localization key to placeholder#19
Muhammadbarznji wants to merge 4 commits intolukeredpath:mainfrom
Muhammadbarznji:feature/support-localization

Conversation

@Muhammadbarznji
Copy link
Copy Markdown

Overview

This PR adds additional snapshot tests for the ResponsiveTextField component and includes tests for Arabic localization. These changes address issue #11 and enhance our test coverage by ensuring the component behaves correctly under various configurations and locales.

Changes

Tests Added

  • testTextFieldInArabic: Checks the text field in the Arabic locale, both empty and with text.
  • testTextFieldWithDifferentConfigurations: Checks the text field with different configurations (empty, no autocorrect, no autocapitalization).

Related Issue

This PR addresses issue #11.

Screenshots

swift-responsive-textfield.mp4

Checklist

  • Added snapshot tests for ResponsiveTextField.
  • Included Arabic localization tests.

Please review the changes and provide feedback. Thank you!

@Muhammadbarznji
Copy link
Copy Markdown
Author

Hi @lukeredpath ,
I’ve added a new feature to the swift-responsive-textfield package, but I’m running into an issue with the GitHub CI action related to Code Climate. The error message is:
The process '/Users/runner/work/swift-responsive-textfield/swift-responsive-textfield/cc-reporter' failed with exit code 255
Any ideas on how to resolve this?

@lukeredpath
Copy link
Copy Markdown
Owner

@Muhammadbarznji thanks for the PR - I will take a look. Don't worry about the CodeClimate step.

@Muhammadbarznji
Copy link
Copy Markdown
Author

Hi @lukeredpath, any update?

@lukeredpath
Copy link
Copy Markdown
Owner

@Muhammadbarznji sorry for not picking this up before. This looks good to me. I don't have time to sort out CI on here right now but I'm happy to merge this in if you're happy with it.

@Muhammadbarznji
Copy link
Copy Markdown
Author

Hi @lukeredpath, Thanks for the feedback! Since you're happy with the changes, I've gone ahead and updated the CI configuration to fix that failing check.

@lukeredpath
Copy link
Copy Markdown
Owner

@Muhammadbarznji still not passing but if you have some time to look into this, that would be great. I'm not opposed running CI on iOS 26 only for now and updating the snapshots if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants