Add localization key to placeholder#19
Add localization key to placeholder#19Muhammadbarznji wants to merge 4 commits intolukeredpath:mainfrom
Conversation
|
Hi @lukeredpath , |
|
@Muhammadbarznji thanks for the PR - I will take a look. Don't worry about the CodeClimate step. |
|
Hi @lukeredpath, any update? |
|
@Muhammadbarznji sorry for not picking this up before. This looks good to me. I don't have time to sort out CI on here right now but I'm happy to merge this in if you're happy with it. |
|
Hi @lukeredpath, Thanks for the feedback! Since you're happy with the changes, I've gone ahead and updated the CI configuration to fix that failing check. |
|
@Muhammadbarznji still not passing but if you have some time to look into this, that would be great. I'm not opposed running CI on iOS 26 only for now and updating the snapshots if needed. |
Overview
This PR adds additional snapshot tests for the
ResponsiveTextFieldcomponent and includes tests for Arabic localization. These changes address issue #11 and enhance our test coverage by ensuring the component behaves correctly under various configurations and locales.Changes
Tests Added
testTextFieldInArabic: Checks the text field in the Arabic locale, both empty and with text.testTextFieldWithDifferentConfigurations: Checks the text field with different configurations (empty, no autocorrect, no autocapitalization).Related Issue
This PR addresses issue #11.
Screenshots
swift-responsive-textfield.mp4
Checklist
ResponsiveTextField.Please review the changes and provide feedback. Thank you!