Skip to content

Cleanup for v0.1.0 release#40

Merged
zheylmun merged 6 commits into
mainfrom
feature/v0.1.0_prep
Apr 2, 2026
Merged

Cleanup for v0.1.0 release#40
zheylmun merged 6 commits into
mainfrom
feature/v0.1.0_prep

Conversation

@zheylmun
Copy link
Copy Markdown
Contributor

@zheylmun zheylmun commented Apr 1, 2026

No description provided.

The derive macro only generated `impl Identifier for T {}`, which is
trivially accomplished by a macro_rules macro. This eliminates a
separate crate to publish and maintain.
No longer needed after replacing the proc-macro with macro_rules.
@zheylmun zheylmun self-assigned this Apr 1, 2026
@zheylmun zheylmun requested a review from JustinKovacich April 1, 2026 13:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/common/communication_control_type.rs 96.92% <ø> (ø)
src/common/communication_type.rs 97.05% <ø> (ø)
src/common/diagnostic_identifier.rs 28.94% <ø> (ø)
src/common/diagnostic_session_type.rs 94.73% <ø> (ø)
src/common/negative_response_code.rs 0.00% <ø> (ø)
src/common/reset_type.rs 96.66% <ø> (ø)
src/common/security_access_type.rs 96.61% <ø> (ø)
src/lib.rs 80.48% <ø> (ø)
src/protocol_definitions.rs 40.42% <ø> (ø)
src/request.rs 39.43% <ø> (ø)
... and 9 more

Copy link
Copy Markdown
Contributor

@JustinKovacich JustinKovacich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zheylmun zheylmun enabled auto-merge April 2, 2026 14:05
@zheylmun zheylmun disabled auto-merge April 2, 2026 14:05
@zheylmun zheylmun merged commit 560ff94 into main Apr 2, 2026
8 checks passed
@zheylmun zheylmun deleted the feature/v0.1.0_prep branch April 2, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants