Skip to content

Fixes to modelconverter analyze#244

Open
dtronmans wants to merge 8 commits into
mainfrom
fix/analyze
Open

Fixes to modelconverter analyze#244
dtronmans wants to merge 8 commits into
mainfrom
fix/analyze

Conversation

@dtronmans

Copy link
Copy Markdown
Contributor

Purpose

Summary of the fixes needed:

  • Stop recreating the modified ONNX multiple times: generate the temporary modified ONNX once and reuse it for collecting debug output names and comparing ONNX vs DLC.
  • Capture the raw debug tensor names that SNPE writes.
  • Create the required output directories on the device before running snpe-net-run.
  • Strip leading "/" from SNPE tensor names before joining paths (had a problem with "/" in module names).
  • Log actual SNPE stdout/stderr on failure instead of only showing a Python CalledProcessError.

Also adapted the README to include the more precise command for running modelconverter analyze

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

@dtronmans dtronmans requested a review from a team as a code owner June 9, 2026 07:04
@dtronmans dtronmans requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team June 9, 2026 07:04
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@dtronmans, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2cc8314-4e7b-4d3d-aa42-8be620eb8c3f

📥 Commits

Reviewing files that changed from the base of the PR and between 6da1965 and 50faa78.

📒 Files selected for processing (4)
  • README.md
  • constraints.txt
  • docker/rvc4/Dockerfile
  • modelconverter/packages/rvc4/analyze.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/analyze

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant