Serialize calls to Dns.Callback#9561
Merged
Merged
Conversation
We had a bug where these calls could be made in parallel. Making them serial is a bit awkward but doesn't require any locks if we're clever.
yschimke
reviewed
Jul 19, 2026
| ) | ||
| } | ||
|
|
||
| private tailrec fun updateStateAndCallCallbacks( |
Collaborator
There was a problem hiding this comment.
Nice. I am curious if it's materially faster than simple synchronisation?
Collaborator
Author
There was a problem hiding this comment.
Probably not! But I prefer lock-free 'cause it only covers data, not execution.
yschimke
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bug where these calls could be made in parallel. Making them serial is a bit awkward but doesn't require any locks if we're clever.