Use proto reader iterator when proto enabled#2375
Open
Conversation
justinjc
force-pushed
the
juchan/proto-iter
branch
from
aae7669 to
d1fe6aa
Compare
| intOptimized := m3tsz.DefaultIntOptimizationEnabled | ||
| return m3tsz.NewReaderIterator(r, intOptimized, encodingOpts) | ||
| v = v.SetReaderIteratorAllocate(func(r io.Reader, descr namespace.SchemaDescr) encoding.ReaderIterator { | ||
| if c.Proto != nil && c.Proto.Enabled { |
Collaborator
There was a problem hiding this comment.
Hm instead of this if/else here, can you just entirely override with:
v = v.SetReaderIteratorAllocate(func(r io.Reader, descr namespace.SchemaDescr) encoding.ReaderIterator {
return proto.NewIterator(r, descr, encodingOpts)
})From within the block below?
if c.Proto != nil && c.Proto.Enabled {
v = v.SetXyz(...)
// ..
}
| }) | ||
|
|
||
| if c.Proto != nil && c.Proto.Enabled { | ||
| v = v.SetReaderIteratorAllocate(func(r io.Reader, descr namespace.SchemaDescr) encoding.ReaderIterator { |
Contributor
There was a problem hiding this comment.
As discussed in chat--let's add a unittest for this and then I'm good.
robskillington
force-pushed
the
master
branch
from
834e25e to
99f874f
Compare
robskillington
force-pushed
the
master
branch
from
e130b7e to
3cf877e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
========================================
- Coverage 71.7% 71.7% -0.1%
========================================
Files 1051 1051
Lines 92476 92479 +3
========================================
- Hits 66383 66381 -2
- Misses 21655 21658 +3
- Partials 4438 4440 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use the proto
encoding.ReaderIteratorwhen proto is enabled.Special notes for your reviewer: N/A
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: