Open
Conversation
Author
|
Hi, anyone? @yamamuteki |
Hi-king
reviewed
Aug 3, 2021
| try: | ||
| if s.shape_type in [1, 14, 17]: | ||
| collect.append(s) | ||
| except Exception as err: |
Member
There was a problem hiding this comment.
@TRANTANKHOA
[ASK] Is this intending to catch AttributeError for s.shape_type ?
I think catching Exception is too broad and wondering if we can use if statement ( e.g. if hasattr(s, 'shape_type') )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, there are some new powerpoint shapes which create exceptions when running the tool. This would fix that by ignoring those "unimplemented" exceptions