Skip to content

fix: Validate js-sdk-file input for Gradle 8 compatibility #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 1 commit into from
Jan 30, 2026
Merged

fix: Validate js-sdk-file input for Gradle 8 compatibility #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions testutils/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,18 @@ android {
}

file("../android-core/src/androidTest/res/raw").mkdir()
def file = file("../android-core/src/androidTest/res/raw/mparticle_js_sdk")
file.createNewFile()
def jsSdkRawFile = file("../android-core/src/androidTest/res/raw/mparticle_js_sdk")
jsSdkRawFile.createNewFile()
if (project.hasProperty('js-sdk-file')) {
file.text = new File(project.property('js-sdk-file')).text
buildConfigField 'boolean', 'JS_TEST_SDK', 'true'
def jsSdkPath = project.property('js-sdk-file')
def jsSdkSourceFile = file(jsSdkPath)
if (jsSdkSourceFile.exists() && jsSdkSourceFile.isFile()) {
jsSdkRawFile.text = jsSdkSourceFile.text
buildConfigField 'boolean', 'JS_TEST_SDK', 'true'
} else {
logger.warn("js-sdk-file was provided but does not exist or is not a file: ${jsSdkPath}. Falling back to remote JS SDK fetch.")
buildConfigField 'boolean', 'JS_TEST_SDK', 'false'
}
} else {
buildConfigField 'boolean', 'JS_TEST_SDK', 'false'
}
Expand Down
Loading