Handle empty CTE body in with_queries#662
Closed
santhreal wants to merge 4 commits into
Closed
Conversation
WITH a AS () leaves cte.this as None; calling _body_sql on it raised AttributeError. Treat an empty body as an empty SQL string.
Share empty-body handling between extract_cte_bodies and the subquery walker instead of a loop-local continue.
Empty CTE bodies re-fed into Parser("") asserted in _require_ast when
resolving columns. Skip blank definitions at the nested-parser boundary.
Cover sibling star resolution and qualified a.*/a.x so either empty-body guard deletion turns the suite red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedQueryResolver._body_sql / with_queries hits AttributeError when WITH a AS () SELECT 1. This PR fixes the regression with a focused test covering the case. claimed