Add 'main' entry to package.json#151
Open
chrisparton1991 wants to merge 1 commit intomachineboy2045:masterfrom
chrisparton1991:add-npm-main
Open
Add 'main' entry to package.json#151chrisparton1991 wants to merge 1 commit intomachineboy2045:masterfrom chrisparton1991:add-npm-main
chrisparton1991 wants to merge 1 commit intomachineboy2045:masterfrom
chrisparton1991:add-npm-main
Conversation
|
Can this be merged ? This is a must have for more an more developer which are using dependencies manager like requireJs or Webpack. |
ghost
approved these changes
Nov 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the library to be require()-d from
node_modulesby specifying the main dist file in package.json.I'm not sure what the policy is around editing CHANGELOG.md, should I bump the version and add an entry as part of this PR? Assuming you think this change is worth merging in, of course.