fix: remove bogus ncc dependency that introduces ws vulnerabilities#275
Open
GJaubert wants to merge 1 commit intomachulav:mainfrom
Open
fix: remove bogus ncc dependency that introduces ws vulnerabilities#275GJaubert wants to merge 1 commit intomachulav:mainfrom
GJaubert wants to merge 1 commit intomachulav:mainfrom
Conversation
PR machulav#230 accidentally added `ncc` (node-chrome-canvas) to dependencies. This is unrelated to `@vercel/ncc` (already in devDependencies) and pulls in ws@2.3.1 which has multiple known vulnerabilities: - GHSA-3648-7jhf-9vrq (DoS via many HTTP headers — high) - CVE-2024-37890 (Denial of Service in ws — high) Remove the bogus dependency and regenerate the lock file. Closes machulav#273
GJaubert
force-pushed
the
fix/remove-bogus-ncc-dependency
branch
from
b3296c9 to
4ae2523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ncc(node-chrome-canvas) fromdependencies— it was accidentally added in PR added the code from pull #224 #230 and is unrelated to@vercel/ncc(the actual build tool, already indevDependencies)ws@2.3.1, which has multiple known high-severity vulnerabilities:package-lock.jsonto remove all transitive dependencies from the bogus packageCloses #273