Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized on 2026-10-18: current head
097f8bc36a7f23792df187234532691ade74cc96includes upstream/main1d2e24849c9d8441b9614acade5252c9937a2bbfthrough a regular merge. Proposal fixes and regression files remain unchanged. All proposal tests and the new upstream client-tool CPU/live and grammar upgrade/release gates are retained. Local baseline PR checks and complete portable Python compilation passed. Earlier revision-specific results below remain historical evidence.Fresh complete Ubuntu 24.04/Python 3.12 CPU integration passed: https://github.com/EmilienIT/vllm-radiance/actions/runs/39142861907, integration head
e840f823c973e14c17e990fec52b0d2deb65bbae. Repository 259 passed/19 existing native skips and 188 subtests passed; conformance 198 passed; D7 repair 230 passed/1 existing artifact skip; NVFP4 conversion 10 passed; FP8/TunableOp source checks passed. Total: 697 passed cases and 20 explicit existing skips, plus baseline/artifact checks and subtests. This is combined-proposal CPU evidence, not a standalone upstream run.The contributor has no R9700. Candidate-image, native ROCm/HIP, physical TP2/TP4, performance and release qualification remain NOT RUN. Maintainer hardware/runtime qualification is required before promoting runtime changes or publishing an image.
run_autocurrently uses Python truthiness for registry eligibility and never verifies the hardware boundary. A quoted YAMLautomatic: "false"is truthy, and an entry mistakenly markedautomatic: trueforr9700ormaintenance-window-r9700-tp2is executed. The validator also accepts these configurations. This contradicts the existing automatic-CPU/manual-hardware contract.Require boolean eligibility flags, reject non-CPU automatic entries, and preflight the complete selected plan before launching its first command. Enforce the same invariants in control-plane validation. Valid CPU automatic entries still execute, manual hardware entries remain explicit, and dry runs execute nothing. All currently registered checks already satisfy these constraints.
Proposal head:
8da55d3a69748f72d245ff1f498123dcbd8b3a86, based on upstream1d9016bbcd5136b12a11dee285ffb614d9b577e3.Validation:
e3f4437ded0c3bc633971f62204605d2945ac2d1: repository tests 167 passed / 19 existing native skips; conformance 198 passed; D7 CPU repair 230 passed / 1 existing compiler-artifact skip; NVFP4 CPU conversion 10 passed; FP8/TunableOp artifact source checks passed.git diff --checkpassed.run_autofunction is AST-identical to the integration; validator, regression tests and policy text match byte for byte. The integration additionally contains fix: include local Codex edits in test selection and add CPU PR checks #16's pending selector/workflow and the independent review proposals; this is not a standalone upstream run. All regression IDs are retained in its registry.fcntlunavailable); the failure is retained. It passed in full on Ubuntu, without excluding those tests.The contributor has no R9700. Candidate-image, ROCm/GPU, dual-R9700 TP2, live correctness, performance and release qualification: NOT RUN. CPU-qualified maintenance behavior only; no hardware qualification is implied. Maintainer physical-GPU qualification remains required before publishing runtime changes. This change neither modifies runtime defaults nor weakens a manual hardware gate.
Includes the mechanical #16 rename of the inherited comment-only Docker workflow to
.yml.disabled, preventing invalid-workflow failure notifications. No executable check is disabled, and GitLab publication is unchanged. Original failed runs are preserved. No merge or image publication performed.