#14003 Faults: Use NNCs to extend fault face detection#959
Open
magnesj wants to merge 2 commits into
Open
Conversation
Extend RigMainGrid::calculateFaults to add fault faces from eclipse-read NNCs with a resolved face direction that are not already covered by an existing fault. Building polygons for eclipse connections is triggered from within the function so face directions are available at fault detection time. Extend RigMainGrid::distributeNNCsToFaults to cover NNCs synthesized later by computeAdditionalNncs, including the asymmetric case where one side of the NNC face is already part of a fault but the other side is not (common at LGR boundaries). Existing fault assignments in the accumulator are preserved. Add a DISABLED unit test (RigDrogonHistNestedFault-Test) that imports the DROGON_HIST_NESTED hybrid-grid EGRID and verifies every NNC with a resolved face direction now maps to an existing fault face.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RigMainGrid::calculateFaultsnow augments geometric fault detection with eclipse-read NNCs that have a resolved face direction. It triggersbuildPolygonsForEclipseConnectionsso faces are available at fault-detection time, then appends a fault face to the appropriate unnamed fault for every NNC face not already covered.RigMainGrid::distributeNNCsToFaultscovers the rest: NNCs synthesized later bycomputeAdditionalNncs, and the asymmetric case where one side of the NNC face is already part of a fault but the other side is not (typical at LGR boundaries). Pre-existing fault assignments in the accumulator are preserved.DROGON_HIST_NESTED.EGRIDand verifies every NNC with a resolved face direction now maps to an existing fault face.Related issue: OPM#14003