jlexer: enforce RFC 8259 number grammar (no leading zeros)#442
Open
omkhar wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fetchNumberaccepts number literals that violate the RFC 8259 number grammar — leading zeros ({"i":01}→1,007→7,0123→123as decimal,-007→-7) and a trailing dot ({"f":1.}→1).encoding/jsonrejects all of these ("invalid character … after …").Same parser-differential / JSON-interoperability class as #375: a strict validator rejects the document as malformed while easyjson silently accepts it and assigns a non-obvious value.
Reproduce (current master):
{"i":01}decodes with a nil error intoI=1;encoding/jsonrejects it.Fix
Enforce the RFC 8259 number grammar in
fetchNumber: reject a leading zero in the integer part followed by another digit, and require at least one digit after.and aftere/E.jlexer/lexer.go: +44/-3, contained tofetchNumber.go test ./...passes (jlexer, gen, parser, buffer, tests).Same rollout question as the control-char change: this tightens default parsing. If you'd prefer it opt-in (cf.
-disallow_duplicate_fields, #375;-disallow_unknown_fields), happy to rework. Flagging the trade-off rather than assuming.