Fall back to Go module build info when version isn't set via ldflags#443
Open
stickpro wants to merge 1 commit into
Open
Fall back to Go module build info when version isn't set via ldflags#443stickpro wants to merge 1 commit into
stickpro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version/Commit(added in feat: Add version and commit information to easyjson generator #424) are only populated via-ldflagsat release build time (see Makefile).go install github.com/mailru/easyjson/easyjson@v0.9.2doesn't pass those flags, so the installed binary always reportsversion: dev/commit: none.versionInfo()now falls back toruntime/debug.ReadBuildInfo()whenVersion/Commitare left at their defaults, picking up the module version and VCS revision that the Go toolchain embeds automatically for bothgo install pkg@versionand localgo buildin a git checkout. ldflags-set values (used by the release Makefile) still take priority.Closes #438