Repository navigation
Conversation
It had no tests. These run it through babel-plugin-ember-template-compilation v2, which is what ember-cli-htmlbars uses, and pin down how it rewrites and which modules it treats as the app's.
babel-plugin-ember-template-compilation v4, which Embroider uses, sets neither env.meta.moduleName nor env.moduleName, only env.filename, so every template threw. Check all three, keeping the old precedence for the path that feeds the id pattern, so classic output is unchanged. The template tests now run against v4 as well as v2.
This was referenced Oct 20, 2026
The replacer assigned arguments[1] and arguments[2] by index, so a call
with no values printed as intl.t('key', ). The fixtures didn't catch it
because babel-plugin-tester runs the output through prettier, which
drops the trailing comma, so the new tests read babel's own output.
Under Embroider + Vite, ember-intl's own source goes through the app's
babel pass. Its internal intl.formatMessage(descriptor, values) was
rewritten to intl.t('[sha512:contenthash:base64:6]', values), with the
raw id pattern as the key.
The replacer now fires only when the first argument is an object
literal with defaultMessage or id. Neither transform touches files under
node_modules any more, apart from an app old Embroider stages there,
since libraries ship already compiled.
Nothing tested index.js. These stand the addon up with a stub host and check the htmlbars registry entry, the parallel-babel descriptor ember-cli rebuilds the plugin from in workers, option merging, and that the babel plugin is added once.
ember-cli-htmlbars passes baseDir() to hash-for-dep to build its cache
key, and expects the plugin's own package (its own plugins use
__dirname). path.resolve('./') is the app's root, so every build hashed
the app's whole dependency graph instead.
eslint 8 is end of life and babel-plugin-tester was on a canary. eslint 10 rejects the /* eslint-env */ comment in template-plugin.js; the flat config already gives every file node globals.
release-plan 0.20 needs Node 22 or later, so the release workflows move off Node 18, which the engines field doesn't allow anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting up #16. Draft because it builds on #17, #18, #19 and #20. Only the last 2 commits are new here; I'll rebase once those land.
eslint 8 is end of life and babel-plugin-tester was on a canary. release-plan 0.20 needs Node 22+, so the release workflows move off Node 18.