Conversation
- 70% faster - 4.3x smaller bytecode
Owner
Author
|
Who invited copilot dawg what |
Move the WinRT BLE transport, mini_asyncio runtime, theme store, and shared types out of dm40/ and into shared/, leaving dm40/ as a device-specific handler package. - shared/base_app: single-window Tk app with scan, connect, waveform, raw packet view, and dynamic handler dispatch. - shared/ble_worker: transport worker with a device-family probe used before handler selection. - shared/device_registry: central table mapping advertised names and probe replies to handler modules. - dm40/app: convert to a handler driven by base_app instead of owning the Tk root.
Add an EL15 handler covering live voltage, current, power, and temperature telemetry, the waveform view, and on-device controls (load on/off, CC/CV/CR/CP/CAP/DCR mode switching, setpoint entry). Device-only modes (POW, ADV [L], ADV [S], DT) are reflected in the UI as a single disabled status button.
- waveform_view: draw the hover/pin tooltip directly on the canvas and remove the standalone Tooltip widget, reducing widget churn and binary size. - build_release.cmd: small flag tweak for the size-optimized release build. - README: restructure with a contents outline, consolidated features, device support with EL15 coverage, and cleaner protocol notes. - utils/themes.md: minor wording pass.
maj113
force-pushed
the
Multi-Device-support
branch
from
09e384f to
38e60d1
Compare
Co-authored-by: Copilot <copilot@github.com>
|
28b for parsing cp? I'd do 25max |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the codebase from a single DM40-only app into a device-agnostic framework and adds an experimental EL15 electronic load handler.
Changes
Architecture refactor
shared/base_app.py— device-independent UI (BLE scanning, connection lifecycle, raw packet log, waveform, stats) extracted into a reusableAppbase classshared/ble_worker.py— BLE transport decoupled from device logic; emits typed callbacksshared/device_registry.py— maps device-type strings to handler classes, BLE name prefixes, and discovery family bytes; local imports insideload_handler()break the circular import while remaining statically traceable by Nuitkadm40/app.py— existing logic moved intoDM40Handler; no functional changesEL15 handler (experimental)
_last_valid_modeprevents fault-bit collisions (CAP↔CC, DCR↔CV) from corrupting the mode displayOther