[codex] add tvOS app download support#478
Conversation
Lakr233
force-pushed
the
codex/download-tvos-apps
branch
from
a34db02 to
f039b44
Compare
|
Is it possible to add support for viewing version ids for tvOS apps? |
|
It's not gonna be made in this PR. |
| if externalVersionID == "" && input.Platform != "" { | ||
| externalVersionID, err = t.lookupLatestExternalVersionID(input.Account, input.App, input.Platform) | ||
| if err != nil { | ||
| return DownloadOutput{}, fmt.Errorf("failed to resolve platform version: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm wondering whether we really need to branch out for the default iOS/iPadOS platform route to the new path being introduced here. Maybe it's enough to just do this for tvOS apps. What are your thoughts?
There was a problem hiding this comment.
Agreed. I restricted the automatic platform external version lookup to tvOS only in 5d45605. iPhone/iPad download requests now use the standard request path. Explicit --external-version-id still goes straight through. Added coverage for iPhone and iPad request payloads.
Validation: go generate ./..., go test ./..., go build ./..., git diff --check.
E2E with an authenticated account: tvOS Speedtest download succeeded and declares AppleTVOS; default Calculator download succeeded with iPhoneOS; explicit iPad Calculator download succeeded with UIDeviceFamily=2.
3 participants
What changed
--platformflag forsearchanddownload.Issues
Closes #46
Related #27
Validation
go generate ./...go test ./...go build ./...~/.ipatoolcredentials: refreshed auth token, searchedInfusewith--platform appletv, downloadedcom.firecore.infuseto/tmp/ipatool-tvos-test/infuse-appletv.ipa, and verifiedPayload/infuse.app/Info.plistdeclaresCFBundleSupportedPlatforms = AppleTVOS.No credentials, cookies, account files, or downloaded IPA files are included in this PR.