Fix 429 rate limit handling and context key type mismatch in login #480#481
Open
rudSarkar wants to merge 1 commit into
Open
Fix 429 rate limit handling and context key type mismatch in login #480#481rudSarkar wants to merge 1 commit into
rudSarkar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces minor improvements for better code clarity and error handling. The most important changes are:
Error handling improvements:
pkg/http/client.go, returning a clear error message when rate limited by Apple.Code clarity:
loginCmdfunction incmd/auth.goto use theinteractiveKeyconstant for context value access, improving type safety and maintainability.Summary by cubic
Adds explicit handling for HTTP 429 (Too Many Requests) from Apple with a clear error, and fixes the login context key mismatch by using the
interactiveKeyconstant. This prevents confusing failures under rate limiting and improves type safety.Written for commit 88922f5. Summary will update on new commits. Review in cubic