Awards page polish: clean anchors, paper counts, name spacing; retire import_awards#1356
Merged
Conversation
…pacing
- Section anchor IDs are now clean/shareable (#student-awards, #best-paper-awards)
instead of #section-...-heading.
- Best/Other Paper Award headings show a count, e.g. 'Best Paper Awards (12)'.
- Recipient/project lists no longer render a stray space before the comma
('Name, Project' not 'Name , Project') — was template whitespace between the loops.
- Adds regression tests for the spacing and the anchor/count changes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The one-time backfill has run on test + prod, so remove its docker-entrypoint.sh step (stops re-running every deploy and resurrecting admin-deleted awards). The import_awards command + tests stay in the repo, unwired and re-runnable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1355 (Awards redesign), addressing review feedback after it shipped to prod in 2.14.0.
Changes
#student-awards,#faculty-honors,#project-awards,#best-paper-awards,#other-paper-awardsinstead of the verbose#section-…-heading. Nicer for sharing direct links.import_awardsfrom the deploy — the one-time backfill has run on test + prod, so it's removed fromdocker-entrypoint.sh. It no longer re-runs every deploy (which would resurrect any award you delete in the admin). The command + tests stay in the repo, unwired and re-runnable.Deploy notes
No schema change. Removing the entrypoint step just means the importer stops running on container start; existing award rows are untouched.
Tests
website/tests/test_award.py— added regression tests for the name spacing and the clean-anchor/count markup. Full award + import suites pass locally (--settings=makeabilitylab.settings_test).Version
Bumps to 2.14.1 (patch).
🤖 Generated with Claude Code