docs: embed demo in README as click-to-play poster - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embed the demo in the README the way GitHub actually renders media: a poster frame that plays the MP4 on click.
GitHub’s README sanitizer strips
<video>unless thesrcis auser-attachments/githubusercontent.comCDN URL from a web-UI drag-drop. That upload path needs a signed-in browser (no shared 1Password GitHub login here), so this PR uses the standard click-to-play pattern instead.Changes
site/assets/demo-slop-triptych-poster.jpg— still from the ~8s mark of the triptychREADME.mdDemo section — poster links to…/demo-slop-triptych.mp4, plus text links to the video and landing#demoFollow-up (optional)
True inline
<video controls>in the README needs a one-time GitHub UI upload of the MP4 to get auser-attachmentsURL. Happy to do that if you hand the box a GitHub session.