Repository navigation
fix(ssh): refresh current session authority and secrets - #183
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH shells kept using attach-time channel metadata when refreshing their environment. Adding or rotating a channel secret through the UI therefore did not reach a fresh child shell in an existing SSH connection.
Refresh now reads current channel and user authority, serializes updates, and closes the connection if its authorization or runtime boundary changes. Regression coverage verifies fresh metadata, role/grant revocation, and work-folder changes.
Validation: 3,801 tests passed, 28 optional checks skipped; 50 focused SSH/config tests passed; static checks, secret scan and DCO passed. A real isolated SSH session verified add → rotate → remove without reconnecting and closed after access revocation. Deployed native UI retest remains pending safe restart; the original QA failure is preserved.