Repository navigation
fix(slack): stop progress immediately when a turn is canceled - #184
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping a Slack turn could clear its loading state and then show it again when late runtime or engine updates arrived during process shutdown. Steering a cold engine had the same gap until the previous runner settled.
Close progress immediately when the run is aborted, reject late callbacks, and prevent a canceled turn from starting progress after asynchronous preflight. Repeated stops share the original bounded cleanup, so a predecessor’s pending clear remains part of queue handoff. The cleanup grace is unchanged.
Validation: 3,810 tests passed with coverage floors, 28 optional checks skipped, zero failures. Regression coverage includes late stdout from both engine fixtures, delayed shutdown, preflight cancellation and queued successors. 131 focused tests, static checks, secret scan, security coverage, dependency audit and DCO passed. Independent review approved d625f46. Native deployed retest remains pending safe restart; original QA failures are preserved.