Repository navigation
fix(slack): clear secret inputs after asynchronous form refusal - #185
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack preserved the typed secret after an asynchronous MCP URL refusal because the updated form reused the same input identity. The safe error and non-secret fields appeared correctly, but the token draft stayed populated.
Give token/value inputs a fresh identity after asynchronous refusal. Carry that identity through form metadata, parsing and field errors while preserving non-secret fields and blank-on-edit stored credentials. Authorization remains unchanged.
Validation: six regressions cover Slack-style retained state, both MCP scopes, variable-value refusal and retry parsing; 97 focused tests, static checks, secret scan and DCO passed. Independent review approved b5f073e. Full coverage passed (3,816 tests, 28 optional skips, zero failures), security coverage and dependency audit passed, and every CI check is green; deployed native retest remains pending safe restart. Original native failure is preserved.