Repository navigation
Fix enabled optional providers in channel runtime picker - #186
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin channel Runtime picker only offered Default, Claude and Codex, so enabled optional providers could not be selected and an existing provider pin could render as Default. Populate it from the same enabled adapter manifest used by the global and DM editors, preserving the saved engine/model on unrelated saves.
Validation: a real browser regression failed against beta's original dropdown, then passed with both optional providers, unrelated save/reload, switching providers and disabled-adapter filtering. Three targeted browser tests pass; full coverage passes (3,816 tests, 29 optional skips; the new browser case was also executed explicitly), plus static checks, security coverage, secret scan, dependency audit and DCO.
Live provider acceptance remains recorded separately: isolated admin-browser and real provider execution exposed this defect; native Slack selector branches remain incomplete. No main promotion or production provider configuration changes.