fix: preserve explicit nulls in work item updates - #68
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesWork item update payload
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The update now preserves explicitly cleared fields while continuing to omit fields the caller did not provide, with regression coverage added; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
UpdateWorkItemwithexclude_unset=Trueso explicitNonevalues reach the PATCH bodyAddresses the work-item update case reported in #35.
Tests
pytest— 86 passed, 298 skippedruff check plane/api/work_items/base.py tests/unit/test_work_items.pyblack --check plane/api/work_items/base.py tests/unit/test_work_items.pyNotes
Full-repository Ruff and mypy currently report pre-existing failures outside this two-file change; scoped Ruff and Black checks pass.
Summary by CodeRabbit