Skip to content

fix: hide Pages nav item from guests with no accessible pages#9111

Open
okxint wants to merge 1 commit into
makeplane:masterfrom
okxint:fix/pages-nav-guest-access
Open

fix: hide Pages nav item from guests with no accessible pages#9111
okxint wants to merge 1 commit into
makeplane:masterfrom
okxint:fix/pages-nav-guest-access

Conversation

@okxint
Copy link
Copy Markdown
Contributor

@okxint okxint commented May 21, 2026

Description

When guest_view_all_features is off, the backend restricts guests to only the pages they own. A guest who hasn't created any pages lands on an empty Pages section with no explanation — the nav link is visible but the content area is empty.

Cycles and Modules already exclude GUEST from their access arrays in project-navigation.tsx. This PR does the same for Pages to be consistent and avoid the confusing empty state.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Scenarios

  1. Create a workspace with a guest user (no pages created by the guest)
  2. Verify the Pages nav item is no longer visible in the sidebar
  3. Verify admin and member users still see Pages

References

Fixes #9103

Guests are restricted to only their own pages by the backend when
guest_view_all_features is off. Showing the Pages nav link leads to a
confusing empty sidebar section. Align with Cycles and Modules, which
already exclude GUEST from their access arrays.

Fixes makeplane#9103
@okxint okxint requested a review from sriramveeraghanta as a code owner May 21, 2026 13:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 860ae1a7-a6db-4747-9182-699c2a343aca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant