fix: hide Pages nav item from guests with no accessible pages#9111
Open
okxint wants to merge 1 commit into
Open
fix: hide Pages nav item from guests with no accessible pages#9111okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
Guests are restricted to only their own pages by the backend when guest_view_all_features is off. Showing the Pages nav link leads to a confusing empty sidebar section. Align with Cycles and Modules, which already exclude GUEST from their access arrays. Fixes makeplane#9103
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
guest_view_all_featuresis off, the backend restricts guests to only the pages they own. A guest who hasn't created any pages lands on an empty Pages section with no explanation — the nav link is visible but the content area is empty.Cycles and Modules already exclude
GUESTfrom theiraccessarrays inproject-navigation.tsx. This PR does the same for Pages to be consistent and avoid the confusing empty state.Type of Change
Test Scenarios
References
Fixes #9103