Skip to content

fix: add is_server parameter to S3Storage.__init__ #9114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HermessNRJ wants to merge 1 commit into
base: preview
Choose a base branch
from
+2 −2
Open

fix: add is_server parameter to S3Storage.__init__ #9114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/api/plane/settings/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def url(self, name, parameters=None, expire=None, http_method=None):

"""S3 storage class to generate presigned URLs for S3 objects"""

def __init__(self, request=None):
def __init__(self, request=None, is_server=False):
# Get the AWS credentials and bucket name from the environment
self.aws_access_key_id = os.environ.get("AWS_ACCESS_KEY_ID")
# Use the AWS_SECRET_ACCESS_KEY environment variable for the secret key
Expand All @@ -48,7 +48,7 @@ def __init__(self, request=None):
aws_access_key_id=self.aws_access_key_id,
aws_secret_access_key=self.aws_secret_access_key,
region_name=self.aws_region,
endpoint_url=(f"{endpoint_protocol}://{request.get_host()}" if request else self.aws_s3_endpoint_url),
endpoint_url=(f"{endpoint_protocol}://{request.get_host()}" if request and not is_server else self.aws_s3_endpoint_url),
config=boto3.session.Config(signature_version="s3v4"),
)
else:
Expand Down