chore: add TypeScript linting and formatting with oxlint/oxfmt#44
Merged
Conversation
Introduce oxfmt and oxlint as the project's TypeScript formatter and linter, managed via pnpm. - oxfmt.config.ts: formatter config with singleQuote, 120 print width, sorted imports, excluding .vendor/ and .kiro/ - oxlint.config.ts: linter config with ESLint, Oxc, TypeScript, Unicorn, and Promise rules; k6-specific overrides for JSON.parse patterns - package.json: scripts for fmt, fmt:check, lint, lint:fix - pnpm-workspace.yaml: workspace pointing to scripts/seed/ - .gitignore: add node_modules/ and pnpm-lock.yaml entries
Normalize code style across k6/ and scripts/seed/ files: - single quotes throughout - consistent semicolons (none) - consistent trailing commas in multi-line constructs - sorted import groups (type imports first)
Address all lint findings: - k6/auth.ts, k6/accounts.ts, k6/transactions.ts: remove unused getAuthToken import (authenticatedHeaders() is used instead) - k6/accounts.ts, k6/transactions.ts: mark type-only imports with 'type' specifier (FireflyResource, FireflyListEnvelope, etc.) - scripts/seed/index.ts: remove unused AccountSeed, TransactionSeed imports and unused BOOTSTRAP_KEY constant - scripts/seed/index.ts: rename catch parameter 'err' to 'error' - scripts/ci/setup-env.ts: add explicit 'void' return type on setupEnv()
- aidlc-state.md: add TypeScript Linter/Formatter to Post-Workflow Enhancements as completed - audit.md: log the enhancement session with user decisions - build-instructions.md: add oxfmt/oxlint checks as required local build steps (Step 3); add pnpm prerequisite - build-and-test-summary.md: add TypeScript Code Quality section documenting tooling, scope, and local quality gates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce oxlint (linter) and oxfmt (formatter) as the project's TypeScript tooling, managed via pnpm. All existing TypeScript files have been formatted and lint warnings resolved.
Changes
4 Commits
oxfmt.config.ts,oxlint.config.ts,package.jsonwith pnpm scripts,pnpm-workspace.yaml,.gitignoreentriesk6/andscripts/seed/getAuthToken,AccountSeed,TransactionSeed,BOOTSTRAP_KEY), addtypespecifier, fix catch parameter naming, add explicit return typesaidlc-state.md,audit.md,build-instructions.md,build-and-test-summary.mdConfiguration Highlights
oxfmt.config.ts.vendor//.kiro/oxlint.config.tsJSON.parsepatternspackage.jsonpnpm fmt,pnpm fmt:check,pnpm lint,pnpm lint:fixTooling
Verification
pnpm fmt:check— all files correctly formattedpnpm lint— 0 errors, 0 warnings