client: support incremental multicast group subscription#3397
Draft
client: support incremental multicast group subscription#3397
Conversation
snormore
force-pushed
the
snor/incremental-multicast-subscribe
branch
from
15c450b to
6c668b8
Compare
Remove the guard in the CLI that blocked `doublezero connect multicast` when a multicast service was already running. The onchain subscribe instruction, CLI's find_or_create_user_and_subscribe, and daemon's InfraEqual + UpdateGroups path already support incremental group additions without tearing down the tunnel. Also improve e2e test ergonomics: - Add Make targets: test-debug, test-nobuild, test-keep, test-cleanup - Rename DZ_E2E_DEBUG env var to DEBUG for consistency with shreds repo - Update dev/e2e-test.sh and dev/e2e-until-fail.sh to use Make - Update CLAUDE.md and DEVELOPMENT.md with new Make target usage
snormore
force-pushed
the
snor/incremental-multicast-subscribe
branch
from
6c668b8 to
49d10ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doublezero connect multicastwhen a multicast service was already running — the onchain subscribe instruction, CLI user-subscribe logic, and daemon'sInfraEqual+UpdateGroupspath already support incremental group additions without tearing down the tunneltest-debug,test-nobuild,test-keep,test-cleanup), renameDZ_E2E_DEBUGtoDEBUG, update scripts and docsDiff Breakdown
Mostly test and build ergonomics; the core change is a 17-line deletion.
Key files (click to expand)
client/doublezero/src/command/connect.rs— removed guard that rejected connect when multicast service already runninge2e/main_test.go— addedAddMulticastPublisherGroupSkipAccessPassandAddMulticastSubscriberGroupSkipAccessPasshelpers, renamed debug env vare2e/multicast_test.go— publisher and subscriber both connect incrementally (mg01 first, then add mg02)e2e/qa_multicast_test.go— Phase 2: incremental subscribe-after-subscribe; Phase 3: incremental publish-after-subscribe (cross-role)e2e/Makefile— new targets:test-debug,test-nobuild,test-keep,test-keep-nobuild,test-cleanupMakefile— top-levele2e-test-*targets that forward to e2e/MakefileTesting Verification
TestE2E_Multicaste2e test passes with incremental publish-after-publish and subscribe-after-subscribeTestQA_MulticastPublisherMultipleGroupsQA test passes with incremental subscribe-after-subscribe (Phase 2) and publish-after-subscribe cross-role (Phase 3)doublezerocrate connect/disconnect unit tests pass