modify to make it compatible with clonality.py#38
modify to make it compatible with clonality.py#38dormeight wants to merge 2 commits intomandricigor:masterfrom
Conversation
add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py
compare.repertoires.py
Outdated
|
|
||
| file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+sample_1+".csv" | ||
| file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+".csv" | ||
| file_TCRB_2=args.dir_2+"/TCRB.VJ.FREQ."+sample_2+".csv" |
There was a problem hiding this comment.
Is there a reason you didn't take out the sample_2 in this line?
There was a problem hiding this comment.
oh,my god. I forgot to remove these ones. all sample_1 or sample_2 should be removed
There was a problem hiding this comment.
Great! @mandricigor could you modify the script to amend these two lines as well and create a new pull request?
@smangul1 I don't have authorization to merge a pull request with the master branch. Can you approve it and/or add me as a contributor?
There was a problem hiding this comment.
I merged these changes with the Mangul USC lab fork.
@mandricigor, I recommend merging this patch into your fork.
@dormeight made a good fix.
remove "sample_2"
aaronkarlsberg
left a comment
aaronkarlsberg
left a comment
There was a problem hiding this comment.
Approved! Works with my data.
2 participants
add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py