Added support for SVG icons#205
Added support for SVG icons#205theenadayalank wants to merge 1 commit intomansona:masterfrom theenadayalank:patch_support_svgs
Conversation
|
@theenadayalank thanks for the PR 🎉 I have laid out a vision for this addon in this comment #185 (comment) but I thought I would respond to your PR directly. I want this PR to land (eventually). It's currently not the best experience for devs when they install ember-cli-notifications and it doesn't work out of the box because you need font-awesome configuration. I want to move to SVG as the default with font-awesome or bootstrap as optional. There are a few points on on the PR and how we might need to proceed:
I hope this is useful in some way 😖 |
|
Thank you @mansona for your great suggestions🙂. Sorry for the delay in getting back to you. The talk by Jen Weber about inlining SVG in ember gave me a lot more insights to handle SVGs😉. The icons I used are downloaded from material.io . Yes, they are open sourced icons. I will change the code as per the suggestions you have given and will let you know once I finish the changes💪. |
|
I have pushed my changes. Kindly review the PR and do the needful 🙂 |
|
Hey @theenadayalank, me again 😂 Sorry for the delay but I have actually included your change in #251 (comment) and actually made it the default and only icons for this addon 😱 I also cherry-picked your change so you got the credit in the PR 🎉 thanks again for your contribution and sorry for taking so long to get it sorted |
Now we can able to use SVG icons instead of font icons.