Closed
Conversation
pichfl
force-pushed
the
octanify
branch
4 times, most recently
from
3475f25 to
465b8f8
Compare
pichfl
force-pushed
the
octanify
branch
3 times, most recently
from
317f04a to
704dc63
Compare
Allow defaults to be set and overridden on the notifications service
Contributor
Author
|
Closing in favor of #320 and upcoming PRs to make this easier to reason about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast forwarding into 2021.
I'll most likely have to break this up into multiple pieces, I just wanted to check if this is the right direction.
Features
Breaking
@zIndexon the container, replaces it with a CSS variable (Picked from replace style binding for z-index with CSS variable #272)