fix: don't consume clicks when no onClick given (fix #274)#337
Open
jacobq wants to merge 1 commit intomansona:mainfrom
Open
fix: don't consume clicks when no onClick given (fix #274)#337jacobq wants to merge 1 commit intomansona:mainfrom
jacobq wants to merge 1 commit intomansona:mainfrom
Conversation
Contributor
Author
|
Alternatively, the |
LawnGnome
added a commit
to LawnGnome/crates.io
that referenced
this pull request
Apr 8, 2026
This pulls in the changes on the `crates-io-fork` branch of https://github.com/LawnGnome/ember-cli-notifications, which gets us: * The fix in mansona/ember-cli-notifications#337 for `onClick` handlers. * A new `onDismiss` option.
LawnGnome
added a commit
to rust-lang/crates.io
that referenced
this pull request
Apr 13, 2026
* pnpm: patch ember-cli-notifications This pulls in the changes on the `crates-io-fork` branch of https://github.com/LawnGnome/ember-cli-notifications, which gets us: * The fix in mansona/ember-cli-notifications#337 for `onClick` handlers. * A new `onDismiss` option. * app: track which banner messages have been dismissed * svelte: add `onDismiss` to notification options * svelte: persist the dismissed state of global banner messages * app/services/banner-message: use local storage instead of cookies * svelte: refactor dismissed banner tracking to use local storage * svelte: port notification onDismiss test to use vitest * e2e: add test for banner messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the problems described in #269 and #274 (that #270 was supposed to fix) this PR proposes making the
handleOnClickfunction inert when@onClickis not provided.Demo: https://github.com/jacobq/ecm-clickProblem