Tell the user we collect telemetry when install finishes - #17
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mattpodwysocki
previously approved these changes
Sep 15, 2026
Points to the CLI's README for the full explanation and how to opt out with MAPBOX_CLI_NO_TELEMETRY=1. Skipped when telemetry is already off.
…tion Shorten the message and link straight to https://github.com/mapbox/mapbox-cli#privacy instead of $REPO/$Repo, since that variable's placeholder value doesn't point at the real repo.
zmofei
force-pushed
the
docs/telemetry-install-notice
branch
from
September 15, 2026 06:04
38ab91e to
bd88fd5
Compare
Matches the wording review feedback asked for: states the default plainly, names the exact env var and when to set it, and separates the pointer to more detail rather than bundling it with the opt-out line.
datasveta
requested changes
Sep 15, 2026
datasveta
self-requested a review
September 15, 2026 09:03
datasveta
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a one-time notice to both installers, printed right after the "Installed $version" summary, saying we collect telemetry and how to turn it off. Skipped when telemetry is already off (nothing to opt out of).
Points readers at the CLI's README (
#telemetry) for the full explanation of what's collected and why — see mapbox/mapbox-cli-private (companion PR, pending).Manually verified:
scripts/test-install.shpasses.sh -nandshellcheck -s shclean oninstall.sh.