Repository navigation
Fix stale Arm64 Windows comment in install.ps1 - #54
Merged
Merged
Conversation
…ve build install.ps1's arm64/x64 fallback logic already preferred a native aarch64-pc-windows-msvc build over the emulated x64 one; the comment above it still said Arm64 Windows "has no build of its own yet", written before the native build existed. Now that the build matrix ships it, the comment described a state that no longer holds. Reported in review of the build-matrix change as a good independent follow-up here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
zmofei
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install.ps1's arm64/x64 fallback logic already prefers a nativeaarch64-pc-windows-msvcbuild over the emulated x64 one, but the commentabove it still said Arm64 Windows "has no build of its own yet", written
back when that was true. Now that the build matrix ships the native
target, the comment described a state that no longer holds.
Code behavior is unchanged: this is comment-only.
Flagged in review of the build-matrix change as a good independent
follow-up here, since
install.ps1lives in this repo, not that one.Verification
Ran
scripts/test-install.ps1(offline, no network) after the change:all cases still pass, including "arm64 prefers a native build when the
channel has one." Parsed the file with PowerShell's own parser to
confirm no syntax error.
482 tests,
cargo fmt --checkclean.🤖 Generated with Claude Code