main#4
Open
bradbrowne wants to merge 3779 commits intomapdojo:masterfrom
Open
Conversation
The related code was not implemented after the migration to Elasticsearch. Use CSW GetRecords with dcat output schema to retrieve the metadata in DCAT/RDF format
* Documentation / User guide - searching information improvements * Apply suggestions from code review * Add feedback from code review --------- Co-authored-by: Jody Garnett <jody.garnett@gmail.com>
…ose metadata contact When using the suggestion `create-featurecatalogue-from-wfs` metadata contact was removed.
* Add some docs to hint that setting up in the WSL may be beneficial Using the WSL on Windows means that the unit tests can be run. Due to IntelliJ's good integration into the WSL, this works very seamless with IntelliJ as well * Fix Tests on Windows instead of suggesting WSL This fixes some tests, like XslUtilTest and RemoveSourceMapUrlProcessorTest to include the expected line endings This also adjusts some wro4j classes to work correctly for windows. Previously, some code paths were hardcoded to only work on the D: drive on windows. This fixes all these issues by special casing file:/ URIs, as windows FS will throw an exception when trying to convert those to paths. Wro4j is also adjusted to take backslashes into account, as windows internally uses these instead of forward slashes for path separation. Finally, the ES enforcer script is updated to not use project.baseUri, as this causes compilation errors on windows. This is because these variables are filled before compiling, and on windows this results in paths like "C:\Builds\core-geonetwork", which is invalid, because the backslashes need to be escaped. Use the baseUri instead, as this always contains forward slashes. * Revert unintended whitespace change * Make MessageProducerTest thread-safe This test currently fails sometimes because of concurrent modifications. Adjust it so it uses proper thread safe constructs * Update core/src/test/java/org/fao/geonet/util/XslUtilTest.java --------- Co-authored-by: Jose García <josegar74@gmail.com>
Co-authored-by: Joachim Nielandt <joachim.nielandt@vlaanderen.be>
…rective.js The workflow will catch any future uncommitted formatting changes
The workflow will catch any future uncommitted formatting changes yamlint
…/mobility-theme.rdf
* Static pages / add support for mail links * Static pages / update documentation page * Update common/src/main/java/org/fao/geonet/utils/EmailUtil.java Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com> * Update common/src/test/java/org/fao/geonet/utils/EmailUtilTest.java Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com> * Update common/src/test/java/org/fao/geonet/utils/EmailUtilTest.java --------- Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com>
* Fix content type returned in resized attachmetns If the attachment is a image and it's resized it is always converted to PNG. Send the `image/png` content type header and change the file name to .png extension. It also add the Content-Length header to the response. Fixes #8558. * Use constants for the Respose headers names
* add session filter for oidc * add more steps to clean up authentication and logout request in filter
…o add new elements, when the tooltips mode is icon (#8664)
- Data services doesn't have distributions
* Header / Portal / Hide logo if not set Avoid to display a broken image if portal logo is not defined. * Admin / Portal / Enable save on logo change. * Admin / Portal: - Save button enabled when selecting a source. - After saving the source, use the selectSource method to setup the form properly. --------- Co-authored-by: Jose García <josegar74@gmail.com>
* CSW Server / Fix processing of wildcard queries. * Remove System.out and commented code
* Formatter / DCAT / Improve dct:references and mime type mapping * If record is children do not duplicate it in siblings * Use specialized relations instead of generic dct:references * Improve mapping for media type * Formatter / DCAT / Add JPEG2000 mapping Co-authored-by: Jose García <josegar74@gmail.com> * Formatter / DCAT / Add additional format mappings --------- Co-authored-by: Jose García <josegar74@gmail.com>
…ematrons as warnings (#8911) * Metadata editor / validation report / display errors for optional schematrons as warnings * Update web-ui/src/main/resources/catalog/locales/en-editor.json Co-authored-by: François Prunayre <fx.prunayre@gmail.com> --------- Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
…rUtil (#8905) * Update bearer token auth to use access token in OAuth2SecurityProviderUtil.java Update bearer token auth to use access token in OAuth2SecurityProviderUtil.java * Remove indentation * Update bean condition in Oauth2 util * Update Update bean condition in SessionExpirationFilter.java
* Update Elasticsearch to v8.19.11 * Documentation / Update Elasticsearch to v8.19.11 * Update pom.xml maven-enforcer-plugin to check the Elasticsearch version number in docker-compose.yml * Update es/pom.xml Co-authored-by: Jody Garnett <jody.garnett@gmail.com> * Update Elasticsearch to v8.19.13 * Documentation / Update Elasticsearch to v8.19.13 --------- Co-authored-by: Jody Garnett <jody.garnett@gmail.com> Co-authored-by: Francois Prunayre <fx.prunayre@gmail.com>
* base tests, iso schematron report, french validation report from it * add test showing validate xsl ignores de diagnosis * fix: use twoCharLangCode for schematron multilingual diagnostic lookup Using substring(lang, 1, 2) fails for languages where the ISO 639-2 code does not truncate to the ISO 639-1 code (e.g. 'ger' -> 'ge' instead of the correct 'de' for German). Replace with util:twoCharLangCode() which correctly maps all 3-letter GeoNetwork language codes to their 2-letter ISO 639-1 equivalents, so that schematron diagnostics tagged with xml:lang="de" (or other non-trivially-truncating codes) are properly selected. * side effect of 54ec902#diff-d57e2feb4046a924e84f5c9cbe3e5d0185f0d4b8b0087a707c9ec27be0f3e8dbR35 --------- Co-authored-by: OCurdy <olivier_curdy@hotmail.com>
* add failing test test fails with: Error on line 1299 of form-builder.xsl: XPTY0004: A sequence of more than one item is not allowed as the second argument of concat() due to #9167. 9167 make linkage mode-iso19115-3.2018#render-element use layout-custom-field instead of layout. but layout-custom-field does NOT support multilingual as well as standard layout. * for multilingual linkage use layout instead of layout-custom-field. anyway, layout-custom-field cannot process multilingual linkage without errors, meaning: it won't provide any doi. adaptating layout-custom-field to support multilingual will require a big refactoring (at least to avoid copy paste), which should not be attempted without tests, to assert that both multilingual linkages and doi for linkage are processed. bypassing doi processing for multilingual linkage helps to provide the first assertion, i.e. multilingual linkages are processed. * make xlinked subtemplate fields read-only in editor
Updated the alt text for the GeoCat link in the readme.
Add health score and contributor badges to README
* Fix creating a new setting in Java code. Previously the value was stored as a null value. * Fix creating a new setting in Java code. Additional unit tests and fix for encrypted values
* Do not set humanized date when not set * Show raw date when no humanize date is active
* This PR contains an API change.
* Add recordPrivilege field to GroupPrivilege
* Display record privilege groups as yellow in privileges panel
* Add legend for reserved and record privilege groups in privileges panel
* Add test for recordPrivilege field in sharing response
* Verify that the GET /{uuid}/sharing endpoint correctly sets
recordPrivilege
* Fix code style in MetadataSharingApi and GroupPrivilege
* Rename legend color classes to avoid Bootstrap 5 name collision
* Add gn- prefix to legend CSS classes
* Hide record privilege legend entry when no such groups exist
* Update managing privileges docs with panel colour coding
---------
Co-authored-by: Juan Luis Rodriguez Ponce <juanluisrp@gmail.com>
* Setting / fix setting editable method. It was setting the internal value instead of the editable value * Update domain/src/main/java/org/fao/geonet/domain/Setting.java Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com> * Fix javadoc comment --------- Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com>
Sort region entries by display name using localeCompare() in gnRegionService.loadRegion() so both the metadata editor region picker and the search form multi-select show results in A-Z order regardless of backend insertion order.
Document the application banner setting introduced in #8416. Includes screenshots for the configuration UI and the banner as displayed in the public search page.
…n't exist (#8350) * Batch editing - In XPATH replace mode don't try to add a node if doesn't exist * Batch editing - In XPATH replace mode don't try to add a node if doesn't exist - Fix unit tests
Removed log4j-slf4j-impl dependency from pom.xml. ``` [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.logging.log4j:log4j-slf4j-impl:jar -> duplicate declaration of version (?) @ line 72, column 17 ```
Adds the missing "Upgrading from GeoNetwork 3.0 Guidance" section to oai-pmh.md so the anchor referenced from the maintainer guide updating page resolves correctly.
* ISO19139 / Add missing namespaces to doi remove process * Remove duplicated namespace --------- Co-authored-by: Juan Luis Rodríguez Ponce <juanluisrp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.