Redesign presets UX: visible list, granular save picker, overlay apply#610
Merged
Conversation
Presets are now overlays: a preset stores only the settings picked in the save dialog, applying sets those and leaves other edits alone. Legacy full-snapshot preset files still apply unchanged through the same flat-dict merge. - sidebar combo replaced with a visible preset list (double-click applies, tooltip summarizes contents) + Apply/Save/Edit/Delete row - GranularSettingsDialog gains ask_name + exclude_sections modes, reused for preset save and edit (rename + re-pick contents) - service exclude_keys deleted; policy now lives in the settings catalog + a Crop/Rotation dialog filter
Apply on top overlays only the preset's non-default fields (legacy snapshots stop clobbering unrelated edits); Replace edits resets the look sections to defaults first, keeping per-frame crop/rotation, metadata, export prefs, dust spots and masks.
Applying a preset opens the granular picker on the preset's own values (untick to skip), targeting current frame, selection or whole visible roll via session.apply_preset_fields — sync_selected_settings sibling that sources from the preset and includes the active frame. Overlay/ replace-look radios subsume the previous QMessageBox; replace prepends look-section reset rows sourced from the preset config's defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GranularSettingsDialog(newask_name+exclude_sectionsmodes): pick exactly which edited settings a preset stores, name it inline; Edit reopens the picker on a preset's own values to rename or re-picksession.apply_preset_fieldsmirrorssync_selected_settingsbut sources from the preset and includes the active frame; other frames get repo writes + external history for undoexclude_keysdeleted — per-frame policy now enforced by settings-catalog membership + a Crop/Rotation filter in the save dialog; legacy preset JSONs still load (migrations included)Test plan
make allgreen (lint, ty, full suite)test_settings_catalog_presets.py(row atomicity, merge/migrations, summaries),test_granular_save_mode.py(save mode, scope/mode radios, gating),test_presets_sidebar.py(list, tooltip, edit-rename, apply_preset_fields current/selection/roll, dialog routing, sync guard)test_retouch_logic.pypreset-exclusion test moved to the new enforcement point (catalog)true_blackpreset migrates on apply