feat: Add hold state filters (Starting, Hand, Foot, Finish) to climb …

[marcodejongh]

…search

Extend the hold filter dropdown to include specific hold states beyond Include/Exclude. Users can now filter climbs that have specific holds marked as Starting, Hand, Foot, or Finish holds.

• Add STARTING, HAND, FOOT, FINISH options to filter dropdown
• Add color configuration for each hold state filter
• Update tag display to show counts for all selected hold states
• Add holdStateFilters support to backend package to match web package

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
boardsesh	Error		Dec 31, 2025 1:50am

[claude]

Claude Review

packages/web/app/components/search-drawer/climb-hold-search-form.tsx

• Lines 10-17: Hardcoded color values violate CLAUDE.md guidelines - should use design tokens from theme-config.ts instead of #06B6D4, #EF4444, #00FF00, etc.
• Line 52: Uses emoji characters (✋, 👣) for icons - consider using consistent Ant Design icons for uniformity with Include/Exclude/Starting/Finish

packages/backend/src/db/queries/climbs/create-climb-filters.ts

• Line 5: Duplicates HoldState type definition - this type already exists in packages/web/app/lib/types.ts:61 and should be shared from packages/shared-schema
• Line 24: The holdsFilter type accepts both HoldState and { state: HoldState } - this dual format adds complexity; consider normalizing during URL parsing instead of handling both forms in the filter logic

[claude]

Claude Review

packages/backend/src/db/queries/climbs/create-climb-filters.ts:141-147

• Potential SQL injection risk: The state parameter is inserted directly into the SQL query via ${state}. While it's filtered to only STARTING/HAND/FOOT/FINISH strings at line 74, consider using parameterized queries for the state value or validating against an explicit enum.

packages/backend/src/db/queries/climbs/create-climb-filters.ts:23

• Type inconsistency: ClimbSearchParams.holdsFilter type is Record<string, HoldState | { state: HoldState }> but ClimbSearchInput.holdsFilter in shared-schema is Record<string, HoldState>. This mismatch could cause runtime errors when data flows between packages.

packages/web/app/components/search-drawer/climb-hold-search-form.tsx:15-22

• Hardcoded dependency on 'kilter' board: HOLD_STATE_COLORS always uses HOLD_STATE_MAP.kilter[...] colors regardless of which board the user is on. This could show incorrect colors for Tension boards.

packages/shared-schema/src/types.ts:7

• 'OFF' state missing from filter options: HoldState includes 'OFF' but it's not handled in the filter dropdown or backend processing - may cause unexpected behavior if 'OFF' is ever used.

[claude]

Claude Review

Potential SQL Injection Risk - create-climb-filters.ts:147: The state variable is user-controlled and used directly in SQL template. While there's a type guard (isValidHoldStateFilter), ensuring it only accepts the 4 hardcoded values, this is safe in practice. However, consider using parameterized values consistently.

Type Mismatch - create-climb-filters.ts:31 vs shared-schema/types.ts:135: The holdsFilter type changed from Record<string, 'ANY' | 'NOT'> to Record<string, HoldState> in ClimbSearchInput, but HoldState includes 'OFF' which isn't handled anywhere. If 'OFF' is passed, it would silently be ignored (not filtered by isValidHoldStateFilter, not matched by 'ANY'/'NOT').

Missing OFF handling - climb-hold-search-form.tsx:16-18: HOLD_STATE_CODES doesn't include 'OFF', but the component's HoldState type includes it. If 'OFF' state exists in uiSearchParams.holdsFilter, holdStateColors[state] at line 115 would return undefined and the tag would be skipped, but the filter would remain in state without any visual indication.