Implement a11y-no-aria-label-misuse linter rule#1677
Open
joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
Open
Implement a11y-no-aria-label-misuse linter rule#1677joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
a11y-no-aria-label-misuse linter rule#1677joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
Conversation
Implements the `a11y-no-aria-label-misuse` rule from erblint-github's `NoAriaLabelMisuse`. This rule flags misuse of `aria-label` and `aria-labelledby` attributes on elements where they are not reliably supported: - Always flags on name-restricted elements: h1-h6, strong, i, p, b, code - Flags on generic elements (div, span) without a role attribute - Flags on generic elements with a prohibited role (none, presentation, paragraph, etc. per W3C namefromprohibited) - Allows usage on interactive elements (button, a, input, etc.) - Allows usage on generic elements with a permitted role (dialog, alert, etc.) Closes marcoroth#1223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
a11y-no-aria-label-misuserule from erblint-github'sNoAriaLabelMisuse.This rule flags misuse of
aria-labelandaria-labelledbyattributes on elements where they are not reliably supported:h1–h6,strong,i,p,b,codediv,span) without aroleattributenone,presentation,paragraph, etc. per W3C namefromprohibited)button,a,input, etc.)dialog,alert, etc.)Closes #1223