Stabilize Android Harness ASan and view lifecycle tests - #1530
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
force-pushed
the
fix/harness-recycling-lifecycle-race
branch
from
August 25, 2026 22:46
abb9999 to
611ab2d
Compare
mrousavy
force-pushed
the
fix/harness-recycling-lifecycle-race
branch
from
August 25, 2026 23:05
611ab2d to
8cbfa3c
Compare
Member
Author
|
That kinda seems like a workaround, not a stable fix |
mrousavy
marked this pull request as draft
August 25, 2026 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Harness rerender completion acknowledges the JavaScript render boundary, not the later Fabric mount transaction and ViewManager lifecycle work. The failing ASan job read the old prepare-for-recycle count during that gap. ASan widened the scheduling window, but the missing native completion barrier was a real race in the test and could also affect Default.
Separate zero-test failures were legacy ASan app_process startup crashes before Nitro loaded. API 33 plus NDK r29 contains both sides of Android's x86_64 sanitizer seccomp fix. Later Android versions are outside maintained ASan compatibility and exhibited stochastic startup crashes, so Default remains on API 36 while the legacy sanitizer row uses API 33.
Evidence:
The sanitizer run also exposed that the intentionally heavy async stress test inherited a 1.5-second helper deadline. Its workload is preserved, but its deadline now reflects sanitizer execution time.
Validation
Follow-up to https://github.com/mrousavy/nitro/actions/runs/32504719667/job/96842180991?pr=1524.
Repeated Android Harness validation
All final-matrix Default and ASan jobs passed in three sequential workflow_dispatch runs: