Skip to content

fix: share token-refresh types and literal template helpers - #209

Open
OskarEichler wants to merge 2 commits into
margelo:mainfrom
OskarEichler:codex/nitro-token-template-literal-values
Open

fix: share token-refresh types and literal template helpers#209
OskarEichler wants to merge 2 commits into
margelo:mainfrom
OskarEichler:codex/nitro-token-template-literal-values

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fixes

  • Share platform-neutral token-refresh configuration and helper implementations between native and web, without importing NitroInstances on web.
  • Include all native configuration fields in web types, including text/body/form-data mappings and onFailure. Web cold-start APIs remain no-ops.
  • Insert dollar sequences literally; process composite placeholders in one pass, support configured hyphenated/prototype-named placeholders and avoid inherited-property lookups.

Compatibility / breaking changes

  • Inserted values are never treated as replacement-string syntax or re-expanded.
  • Unknown/unconfigured composite placeholders now remain literal in JS, matching native behavior; configured missing/null values still become empty.
  • Existing public exports and native runtime entrypoints are preserved; no new dependency or version bump.

Verification

  • Ten external JS cases pass: shared helper identity, dollar sequences, arrays/null/booleans, cross-referencing tokens, missing/unknown/non-word/prototype-named placeholders and Unicode.
  • TypeScript, ESLint and module/declaration builds pass. Shared configuration contains no native imports.
  • No test/spec files added or modified. Native bootstrap corrections are submitted separately.

Fixes #187. Fixes #219.

Consumer follow-up verification

The combined fixes are backported to an immutable 1.6.1 artifact. Both consuming app Android Debug variants, both iOS Debug Simulator variants, four production Metro bundles, 13 web targets, four browser-extension builds, lint and immutable installation pass. All 274 installed non-metadata files match the artifact. This is build verification, not a physical-device authentication/upload certification.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@OskarEichler is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

@OskarEichler OskarEichler changed the title fix: preserve literal dollar sequences in token templates fix: share token-refresh types and literal template helpers Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant