Skip to content

fix: bound inspector history and preserve diagnostic behavior - #210

Open
OskarEichler wants to merge 1 commit into
margelo:mainfrom
OskarEichler:codex/nitro-inspector-bounds-profiling
Open

fix: bound inspector history and preserve diagnostic behavior#210
OskarEichler wants to merge 1 commit into
margelo:mainfrom
OskarEichler:codex/nitro-inspector-bounds-profiling

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fixes

  • Bound retained WebSocket messages per connection, trim history when limits shrink, preserve cumulative counters and reject invalid limits.
  • Use the captured request body in inspector curl output with explicit truncation notes; standalone curl generation preserves empty/long/literal bodies and explicit URL/method arguments.
  • Make Hermes profiling best-effort, protect nested ownership, and preserve the wrapped result/error when profiler APIs are absent or fail.

Compatibility / breaking changes

  • maxMessagesPerSocket defaults to 100. Limits must be non-negative safe integers; shrinking entry/message limits immediately trims existing history.
  • Inspector curl output obeys maxBodyCapture (UTF-16 code units); standalone generateCurl no longer silently truncates long bodies.
  • profilePath is returned only when a profile was actually dumped.

Verification

  • 21 external utility cases pass, including shell argument inspection, retention/counters, profiler failures/nesting and Expo controls (Expo fix is separate).
  • Docs static build, TypeScript, ESLint and package builds pass on combined candidate.

Fixes #191. Fixes #192. Fixes #193.

Changes were reviewed against upstream 627c77e. No test/spec files were added or modified. Release/version selection is left to the maintainers.

Consumer verification

All nine independent PR source overlays pass TypeScript. The combined fixes were backported to the existing 1.6.1 package without upgrading its dependency constraints. Both Android/iOS app variants, four production Metro bundles, 13 web builds, four extension builds and app lint pass. The installed artifact is immutable and its 269 non-metadata files match the build-verified candidate.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@OskarEichler is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant