Skip to content

fix: generate valid idempotent Android Expo bootstrap code - #211

Open
OskarEichler wants to merge 2 commits into
margelo:mainfrom
OskarEichler:codex/nitro-expo-java-kotlin-bootstrap
Open

fix: generate valid idempotent Android Expo bootstrap code#211
OskarEichler wants to merge 2 commits into
margelo:mainfrom
OskarEichler:codex/nitro-expo-java-kotlin-bootstrap

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fixes

  • Insert imports after the package declaration and generate language-correct try/catch syntax.
  • Use the Kotlin object INSTANCE entrypoint from Java and recognize both Java/Kotlin calls on repeated runs.
  • Use the actual config-plugin callback parameter and type.

Compatibility / breaking changes

  • No public API or behavior break intended.

Verification

  • Generated Java and Kotlin Application fixtures compile against the actual built AutoPrefetcher class; both remain unchanged on a second plugin pass.
  • Expo plugin TypeScript check and package lint pass.

Fixes #194.

Changes were reviewed against upstream 627c77e. No test/spec files were added or modified. Release/version selection is left to the maintainers.

Generated plugin output

The root lint configuration now ignores only expo/plugins/dist (already generated and Git-ignored), so compiling the plugin does not create 27 formatting errors in emitted code. Plugin source remains linted. Root lint passes before and after the plugin build. Fixes #220.

Consumer follow-up verification

The combined fixes are backported to an immutable 1.6.1 artifact. Both consuming app Android Debug variants, both iOS Debug Simulator variants, four production Metro bundles, 13 web targets, four browser-extension builds, lint and immutable installation pass. All 274 installed non-metadata files match the artifact. This is build verification, not a physical-device authentication/upload certification.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@OskarEichler is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root lint scans generated Expo plugin dist output after build:plugin Expo Android plugin injects Kotlin into Java MainApplication

1 participant