Skip to content

fix: close Android token-refresh connections on every exit - #215

Open
OskarEichler wants to merge 1 commit into
margelo:mainfrom
OskarEichler:codex/nitro-android-refresh-connection-cleanup
Open

fix: close Android token-refresh connections on every exit#215
OskarEichler wants to merge 1 commit into
margelo:mainfrom
OskarEichler:codex/nitro-android-refresh-connection-cleanup

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fixes

  • Disconnect both Fetch and optional WebSocket HttpURLConnections in finally blocks.
  • Close non-2xx error streams and preserve existing success/failure fallback behavior.

Compatibility / breaking changes

  • No public API or behavior break intended.

Verification

  • Eight compiled Kotlin cases pass: both implementations on success, non-2xx, response-code failure and body-read failure. All eight fail their cleanup assertions on the baseline.
  • Android example builds pass; synthetic connections isolate resource lifecycle without contacting real refresh endpoints.

Fixes #204.

Changes were reviewed against upstream 627c77e. No test/spec files were added or modified. Release/version selection is left to the maintainers.

Consumer verification

All nine independent PR source overlays pass TypeScript. The combined fixes were backported to the existing 1.6.1 package without upgrading its dependency constraints. Both Android/iOS app variants, four production Metro bundles, 13 web builds, four extension builds and app lint pass. The installed artifact is immutable and its 269 non-metadata files match the build-verified candidate.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@OskarEichler is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android token refresh does not disconnect HttpURLConnection on completion or failure

1 participant