fix: encode native multipart names and line breaks correctly - #225
Open
OskarEichler wants to merge 1 commit into
Open
fix: encode native multipart names and line breaks correctly#225OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
@OskarEichler is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Compatibility / breaking changes
Names and text values containing line breaks now use browser-compatible multipart encoding; quotes in parameters become percent-encoded. Invalid multiline MIME types now reject. File bytes, public signatures, buffer strategy and dependency versions are unchanged. This does not implement streaming uploads or bound upload memory.
Verification
24 external native serialization checks pass, executing the actual Swift/Kotlin serializers and comparing bytes with Node FormData (except retaining the existing explicit empty filename, which Node omits). 12 assertions fail on the original source. Both native examples build with tracing enabled; no physical device/network upload claim. No test/spec files changed.
Algorithm reference: HTML multipart encoding.
Fixes #224.
Consumer follow-up verification
The combined fixes are backported to an immutable 1.6.1 artifact. Both consuming app Android Debug variants, both iOS Debug Simulator variants, four production Metro bundles, 13 web targets, four browser-extension builds, lint and immutable installation pass. All 274 installed non-metadata files match the artifact. This is build verification, not a physical-device authentication/upload certification.