fix: use OpenSSL-Universal CocoaPods dependency instead of vendored xcframework#977
Merged
fix: use OpenSSL-Universal CocoaPods dependency instead of vendored xcframework#977
Conversation
…cframework OpenSSL 3.6 is now available on CocoaPods Trunk via OpenSSL-Universal. Replace the custom download/vendoring machinery with a standard pod dependency, which lets CocoaPods deduplicate OpenSSL when other pods (e.g. op-sqlite with SQLCipher) also depend on it. Closes #881
…artifacts Use pessimistic version (~> 3.6) to prevent accidental major-version jumps. Add prepare_command cleanup of vendored OpenSSL.xcframework from pre-1.0.20 installs. Remove extra blank line in .gitignore.
…space dep Podfile.lock reflects the new OpenSSL-Universal CocoaPods dependency. Example app now uses workspace:* to track the local package.
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the self-managed OpenSSL xcframework download (curl + unzip during podspec evaluation and
prepare_command) with a proper CocoaPods dependency onOpenSSL-Universal ~> 3.6.closes #881
closes #900
Changes
QuickCrypto.podspecs.dependency "OpenSSL-Universal", "~> 3.6"— CocoaPods now handles downloading, caching, and linking OpenSSL~> 3.6) to prevent accidental major-version jumpsprepare_commandcleanup of staleOpenSSL.xcframeworkfrom pre-1.0.20 installsOpenSSL.xcframeworkfrom CI cache paths and.gitignorePodfile.lockto reflect the new dependencyworkspace:*instead of pinned versionTesting
pod installinexample/ios/succeeds and resolvesOpenSSL-Universal 3.6.0000