Skip to content

test: Strengthen VisionCamera Harness coverage - #4108

Open
mrousavy wants to merge 3 commits into
mainfrom
agent/improve-harness-tests
Open

test: Strengthen VisionCamera Harness coverage#4108
mrousavy wants to merge 3 commits into
mainfrom
agent/improve-harness-tests

Conversation

@mrousavy

@mrousavy mrousavy commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

  • remove noisy console.log output from the Frame Converter and Resizer Harness suites
  • keep photo, video, and frame replacement scenarios atomic while tightening session, callback, and worklet cleanup
  • compare every selected CameraSessionConfig field between resolveConstraints() and session.configure(...)
  • exercise cinematic stabilization through a real running camera session
  • wait for a real start event and an attached output before selecting 60 FPS during a running-session reconfiguration
  • verify that every advertised iOS video codec is accepted by the output-settings API

Design

These tests intentionally keep one-off setup inline instead of introducing shared helpers or a private test DSL. Setup, teardown, and failure boundaries stay visible in each independent scenario; small amounts of repetition are retained where they make the test behavior clearer.

The constraint suite keeps resolver-focused negotiation coverage and adds one focused end-to-end stabilization path. The reconfiguration test proves the session was running before selecting and applying the new constraint set without polling asynchronous session.isRunning state.

Validation

  • rebased onto current main (9c7456f7)
  • bunx biome check on all six changed Harness files
  • workspace package TypeScript builds
  • bunx tsc --noEmit -p apps/simple-camera/tsconfig.json
  • git diff --check origin/main...HEAD
  • independent post-rebase diff review confirming the current-main session tests were preserved and no unintended changes remain

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-vision-camera-docs Ready Ready Preview, Comment Jul 29, 2026 2:10pm

Request Review

@mrousavy mrousavy changed the title Streamline Harness integration tests chore: Streamline Harness tests (fold multiple into one)= Jul 28, 2026
@mrousavy mrousavy changed the title chore: Streamline Harness tests (fold multiple into one)= chore: Streamline Harness tests (fold multiple into one) Jul 28, 2026
@mrousavy
mrousavy force-pushed the agent/improve-harness-tests branch from 49463f2 to 053f294 Compare July 29, 2026 14:09
@mrousavy mrousavy changed the title chore: Streamline Harness tests (fold multiple into one) test: Strengthen VisionCamera Harness coverage Jul 29, 2026
@mrousavy
mrousavy marked this pull request as ready for review July 29, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant