feat: Add native tap-to-focus reset listener - #4173
Closed
mrousavy wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Too overcomplicated. Let's just not have this feature now, the code got too complex to support this. We can ask the CameraX team to add a on focus reset event |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addOnFocusResetListenerto the native tap-to-focus gesture controllerMeteringTasksuccessfully performs its automatic reset on iOSThis PR is stacked on #4172. It intentionally reports automatic resets from native tap-to-focus gestures only; failed or superseded resets do not emit.
Test plan
bun camera specsbun run lint-allbun camera typecheckbun camera build./apps/simple-camera/android/gradlew -p apps/simple-camera/android :react-native-vision-camera:assembleDebug --no-daemon --console=plainxcodebuild -workspace SimpleCamera.xcworkspace -scheme VisionCamera -sdk iphonesimulator -configuration Debug -destination 'generic/platform=iOS Simulator' -derivedDataPath build CODE_SIGNING_ALLOWED=NO build -quiet