Making TapiLine.cs and TapiManager.cs compatible with NET 7.0 through async

[gitapii]

Hi,

I just modified the methods HandleNewCall() in TapiLine.cs and ProcessTapiMessages() in TapiManager.cs slightly, such that the whole library should work under NET 7.0 now.

Regards,

[exaiwitmx]

Hi @gitapii ,

have you tested this?
I'd guess that it won't compile because you cannot use await in a non-async method.
Also, from what I get, the async calls (BeginInvoke) were not awaited before. So, the behavior would change.

I've also tried to make it run under .NET 9.0 after migrating the library to .NET Standard 2.0 and replacing BeginInvoke by Task.Run, but without awaiting.
The result was that my application works only intermittently. The application listens for incoming calls. The first call usually comes in without problems, but subsequent calls don't. Sometimes, it recovers after some time, sometimes, it doesn't.

Has someone successfully used this library (or anything else based on Tapi3.dll) used under .NET (the new one based on .NET Core)?

[exaiwitmx]

Update: I've managet to get it working:

        private void HandleNewCall(TapiCall call, int callPrivileges)
        {
            if (NewCall != null)
            {
                Privilege priv = (callPrivileges == NativeMethods.LINECALLPRIVILEGE_NONE) ? Privilege.None :
                    (callPrivileges == NativeMethods.LINECALLPRIVILEGE_MONITOR) ? Privilege.Monitor : Privilege.Owner;
                foreach (EventHandler<NewCallEventArgs> nc in NewCall.GetInvocationList())
                {
                    Task.Factory.StartNew(() => nc(this, new NewCallEventArgs(call, priv)), CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default)
                    .ContinueWith((previousTask) =>
                    {
                        AsyncExceptionHelper.LogAggregateException(previousTask.Exception, true, $"Error in {nameof(HandleNewCall)}:");
                    }, TaskContinuationOptions.OnlyOnFaulted);
                }
            }
        }

It started working after I replaced Task.Run by Task.Factory.StartNew and passed TaskCreationOptions.LongRunning to it.
I don’t know the exact reason why this makes a difference - maybe before, it did not create a new thread every time.